fix: update demo data placeholder link#11
Merged
Rl0007 merged 5 commits intoBuildWithHussain:developfrom Nov 23, 2025
Merged
Conversation
Refactored create_style_variant to use a color-to-hex mapping and generate image URLs with appropriate background and text colors. This enhances the placeholder image logic, supports more colors, and ensures better text visibility on generated images.
Refactored create_style_variant to use a color-to-hex mapping and generate image URLs with appropriate background and text colors. This enhances the placeholder image logic, supports more colors, and ensures better text visibility on generated images.
Rl0007
requested changes
Nov 23, 2025
ls_shop/install_demo_data.py
Outdated
| # Route should NOT include language prefix - hooks.py handles that | ||
| route_slug = f"{product_data['code'].lower()}-{color.lower()}" | ||
|
|
||
| # Map your color names to Hex codes |
Collaborator
There was a problem hiding this comment.
Remove unnecessary comments..
ls_shop/install_demo_data.py
Outdated
| "Green": "28A745", | ||
| "Navy": "000080", | ||
| "Gray": "6C757D", | ||
| "XS": "333333", # Fallbacks for sizes if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.