feat: non-otp checkbox in zoom webinar registration doctype

[vishwajeet-13]

new checkbox to store is registration from otp flow or non-otp

Summary by CodeRabbit

• New Features
  • Added a new "Non Otp" checkbox field to Zoom Webinar Registration forms, enabling management of registrations that do not require one-time password verification.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A new non_otp checkbox field is added to the Zoom Webinar Registration DocType. The field is defined in both the JSON configuration file and Python type hints, enabling OTP mode configuration for webinar registrations.

Changes

Cohort / File(s)	Summary
Zoom Webinar Registration DocType zoom_integration/zoom_integration/doctype/zoom_webinar_registration/zoom_webinar_registration.json	Added non_otp Check field with default value 0 and label "Non Otp". Updated field_order to position it after synced_from_zoom.
Zoom Webinar Registration Python zoom_integration/zoom_integration/doctype/zoom_webinar_registration/zoom_webinar_registration.py	Added type hint non_otp: DF.Check in the TYPE_CHECKING block for the ZoomWebinarRegistration class.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A checkbox hops into the form today,
Non-OTP mode shows a different way,
Registration fields grow, bit by tiny bit,
Zoom webinars now have a flexible fit! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a non-otp checkbox field to the zoom webinar registration doctype.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

🧹 Recent nitpick comments

zoom_integration/zoom_integration/doctype/zoom_webinar_registration/zoom_webinar_registration.json (1)

140-145: Consider improving label capitalization and adding a description.

The label "Non Otp" uses inconsistent capitalization for the acronym OTP. Additionally, a description field would help users understand the purpose of this checkbox.

✨ Suggested improvements

  {
   "default": "0",
+  "description": "Check if this registration originated from a non-OTP flow",
   "fieldname": "non_otp",
   "fieldtype": "Check",
-  "label": "Non Otp"
+  "label": "Non OTP"
  }

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3508d4e and 89c779a.

📒 Files selected for processing (2)

• zoom_integration/zoom_integration/doctype/zoom_webinar_registration/zoom_webinar_registration.json
• zoom_integration/zoom_integration/doctype/zoom_webinar_registration/zoom_webinar_registration.py

🔇 Additional comments (2)

zoom_integration/zoom_integration/doctype/zoom_webinar_registration/zoom_webinar_registration.py (1)

27-27: LGTM!

The type hint non_otp: DF.Check correctly corresponds to the new checkbox field defined in the JSON configuration and follows the existing pattern used by synced_from_zoom.

zoom_integration/zoom_integration/doctype/zoom_webinar_registration/zoom_webinar_registration.json (1)

140-145: Verify if the field should be read-only.

If this checkbox is meant to be set programmatically during the registration flow (similar to synced_from_zoom), consider adding "read_only": 1 to prevent accidental manual modification by users.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}