Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the conversion of FLAC files.
Serato stores metadata in the FLAC tag file's SERATO_BEATGRID and SERATO_MARKERS_V2 fields in addition to the usual fields like artist, title, etc. (see here). Using information and code inspired from https://github.com/Holzhaus/serato-tags, the implemented functions read the field data, decode the base64-encoded data, and parse CUE markers and the beatgrid information.
I had some troubles with base64 padding and/or the base64-encoded string having the wrong length, which I "solved" by cutting off the string until it is the right length again. This might lose some data at the end, but so far in my testing, no CUE markers have been lost. Please test it again with your FLAC files to see if my code works on your examples too.
Disclaimer: I used code from https://github.com/Holzhaus/serato-tags which has an MIT license.