Skip to content

Remove GodotSink and remaining GD.Print calls #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmgxyz wants to merge 1 commit into
base: Development
Choose a base branch
from
Open

Remove GodotSink and remaining GD.Print calls #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions C7/GodotSink.cs
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions C7/LogManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,17 @@ public override void _Ready() {
// Includes all logs of an 'Information' level regardless of namespace, and all logs of
// the C7Engine.AI namespace regardless of log level.
Log.Logger = new LoggerConfiguration()
// .WriteTo.GodotSink(formatter: consoleTemplate) //Writing to console can slow the game down considerably (see #278). Thus it is disabled by default.
.WriteTo.File("log.txt", buffered: true, flushToDiskInterval: TimeSpan.FromMilliseconds(250), fileSizeLimitBytes: 52428800, //50 MB
outputTemplate: "[{Level:u3}] {Timestamp:HH:mm:ss} {SourceContext}: {Message:lj} {NewLine}{Exception}")

.Filter.ByIncludingOnly("(@l = 'Fatal' OR @l = 'Error' OR @l = 'Warning' OR @l = 'Information')") //suggested: OR SourceContext like 'C7Engine.AI.%' (insert the namespace you need to debug)
.MinimumLevel.Debug()
.CreateLogger();

GD.Print("Hello logger!");
Log.ForContext<LogManager>().Debug("Hello!");
}

public override void _Notification(int what) {
if (what == ((long)DisplayServer.WindowEvent.CloseRequest)) {
GD.Print("Goodbye logger!");
Log.ForContext<LogManager>().Debug("Goodbye!");
Log.CloseAndFlush();
GetTree().Quit();
Expand Down