Draft
Conversation
fcollman
previously approved these changes
Jan 3, 2024
Contributor
Author
|
@fcollman looks like tests are failing generally (i.e. before this PR) is that a known thing I shouldn't worry about? |
Contributor
Author
|
@fcollman @ceesem would like to bring this back up - i'd like to not have to pin networkx to be <3. Looking back at my changes here, I think it could make sense to just have a function/method for (I think all other diffs were from my autoformatter here) |
Contributor
Author
|
I also don't know whether/how to trust tests here since they seem like they've been failing since I submitted this, lmk any thoughts on that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.