Skip to content

Rock paper Scissors with bot command Elias Cueto #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EliasCueto45 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rock paper Scissors with bot command Elias Cueto #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a4bc85
initial commit for Elias'
Jun 3, 2025
cd72067
RPS working
Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added a.py
View file
Open in desktop
Empty file.
84 changes: 84 additions & 0 deletions src/capy_app/frontend/cogs/onboarding/elias_onboarding_cog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
import discord
import logging
from discord.ext import commands
from discord import app_commands

from frontend import config_colors as colors
from config import settings
import random

class EliasCog(commands.Cog):
Copy link

@sourcery-ai sourcery-ai bot Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (complexity): Consider refactoring the command into a standalone function without a Cog, custom logger, or unused mappings to simplify the implementation.

You can simplify this to a single `@app_commands.command` (no Cog, no custom logger, no unused mapping) while preserving all behavior:

```python
# commands/rps.py

import discord
from discord import app_commands
from discord.ext import commands
from config import settings
from frontend.config_colors import PING as PING_COLOR

@app_commands.guilds(discord.Object(settings.DEBUG_GUILD_ID))
@app_commands.command(name="rps", description="Plays Rock Paper Scissors with the bot")
async def rps(interaction: discord.Interaction):
    embed = discord.Embed(
        title="Rock Paper Scissors",
        description="Choose your reaction",
        color=PING_COLOR,
    )
    await interaction.response.send_message(embed=embed)
    # Grab the sent message and add reactions
    message = await interaction.original_response()
    for emoji in ("🪨", "📄", "✂️", "⭐", "❌"):
        await message.add_reaction(emoji)

Steps to apply:

  1. Drop the EliasCog class and setup function entirely.
  2. Create a new module (commands/rps.py) with the above code.
  3. Ensure your bot’s startup loads commands/rps.py (e.g. via bot.tree.copy_global_to(guild=...) or your existing command loader).
  4. Remove the unused status_emojis dict and custom logger import.

This keeps the slash-command, the embed, and the reactions, with far less indirection.

def __init__(self, bot: commands.Bot):
self.bot = bot
self.logger = logging.getLogger(
f"discord.cog.{self.__class__.__name__.lower()}"
)
self.status_emojis = {
"🪨": "Rock",
"🧻": "Paper",
"✂️": "Scissors",
}

@app_commands.guilds(discord.Object(id=settings.DEBUG_GUILD_ID))
@app_commands.command(name="rps", description="Plays Rock Paper Scissors with the bot!", )
async def rps(self, interaction: discord.Interaction):

message = f"React to play!"
self.logger.info(message)
embed = discord.Embed(
title="Rock Paper Scissors",
description=message,
color=colors.GUILD,
)
await interaction.response.send_message(embed=embed)
msg = await interaction.original_response()
for emoji in self.status_emojis.keys():
await msg.add_reaction(emoji)
self.bot.rps_message_id = msg.id
self.bot.rps_user_id = interaction.user.id

def determine_winner(self, user_choice: str, bot_choice: str) -> str:
if user_choice == bot_choice:
return "tied"
wins_against = {
"Rock": "Scissors",
"Scissors": "Paper",
"Paper": "Rock",
}
if wins_against[user_choice] == bot_choice:
return "won ⭐"
else:
return "lost ❌"

@commands.Cog.listener()
async def on_reaction_add(self, reaction: discord.Reaction, user: discord.User):
if user.bot:
return

if not hasattr(self.bot, "rps_message_id") or reaction.message.id != self.bot.rps_message_id:
return

if user.id != self.bot.rps_user_id:
return

choice = self.status_emojis.get(str(reaction.emoji))
if not choice:
return
# Delete reaction version
await reaction.message.clear_reactions()

#Delete message version
#wait reaction.message.delete()

# Choose bot's random move
import random
bot_choice = random.choice(["Rock", "Paper", "Scissors"])
result = self.determine_winner(choice, bot_choice)

await reaction.message.channel.send(
f"{user.mention} chose **{choice}**, I chose **{bot_choice}**. You **{result}**!"
)


async def setup(bot: commands.Bot):
await bot.add_cog(EliasCog(bot))