Skip to content

feat: support transaction pause #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xbillw merged 1 commit into from
Mar 10, 2025
Merged

feat: support transaction pause #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions standalone/chain/runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ polkadot-sdk = { workspace = true, features = [
"pallet-transaction-payment",
"pallet-transaction-storage",
"pallet-treasury",
"pallet-tx-pause",
"pallet-utility",
"sp-api",
"sp-authority-discovery",
Expand Down
40 changes: 34 additions & 6 deletions standalone/chain/runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ use frame_support::{
traits::{
fungible::{HoldConsideration, NativeFromLeft, NativeOrWithId, UnionOf},
tokens::{imbalance::ResolveAssetTo, pay::PayAssetFromAccount},
AsEnsureOriginWithArg, ConstBool, ConstU128, ConstU32, Currency, EitherOfDiverse, EnsureOriginWithArg,
EqualPrivilegeOnly, Imbalance, InstanceFilter, KeyOwnerProofSystem, LinearStoragePrice, Nothing, OnFinalize,
OnUnbalanced, VariantCountOf,
AsEnsureOriginWithArg, ConstBool, ConstU128, ConstU32, Contains, Currency, EitherOfDiverse,
EnsureOriginWithArg, EqualPrivilegeOnly, Everything, Imbalance, InsideBoth, InstanceFilter,
KeyOwnerProofSystem, LinearStoragePrice, Nothing, OnFinalize, OnUnbalanced, VariantCountOf,
},
weights::{
constants::{BlockExecutionWeight, ExtrinsicBaseWeight, RocksDbWeight, WEIGHT_REF_TIME_PER_MILLIS},
Expand All @@ -62,11 +62,14 @@ use frame_system::{
use pallet_asset_conversion::{AccountIdConverter, Ascending, Chain, WithFirstAsset};
use pallet_asset_conversion_tx_payment::SwapAssetAdapter;
use pallet_election_provider_multi_phase::{GeometricDepositBase, SolutionAccuracyOf};
use pallet_file_bank::migration::SteppedFileBank;
use pallet_im_online::sr25519::AuthorityId as ImOnlineId;
use pallet_session::historical as pallet_session_historical;
use pallet_sminer::migration::SteppedSminer;
#[allow(deprecated)]
pub use pallet_transaction_payment::{CurrencyAdapter, Multiplier, TargetedFeeAdjustment};
use pallet_transaction_payment::{FeeDetails, RuntimeDispatchInfo};
use pallet_tx_pause::RuntimeCallNameOf;
use sp_api::impl_runtime_apis;
use sp_authority_discovery::AuthorityId as AuthorityDiscoveryId;
use sp_consensus_grandpa::AuthorityId as GrandpaId;
Expand All @@ -86,8 +89,6 @@ use sp_staking::currency_to_vote::CurrencyToVote;
use sp_version::NativeVersion;
use sp_version::RuntimeVersion;
use static_assertions::const_assert;
use pallet_file_bank::migration::SteppedFileBank;
use pallet_sminer::migration::SteppedSminer;

// Frontier
use fp_rpc::TransactionStatus;
Expand Down Expand Up @@ -232,8 +233,31 @@ parameter_types! {

const_assert!(NORMAL_DISPATCH_RATIO.deconstruct() >= AVERAGE_ON_INITIALIZE_RATIO.deconstruct());

/// Calls that cannot be paused by the tx-pause pallet.
pub struct TxPauseWhitelistedCalls;
/// Whitelist `Balances::transfer_keep_alive`, all others are pauseable.
impl Contains<RuntimeCallNameOf<Runtime>> for TxPauseWhitelistedCalls {
fn contains(full_name: &RuntimeCallNameOf<Runtime>) -> bool {
match (full_name.0.as_slice(), full_name.1.as_slice()) {
(b"Balances", b"transfer_keep_alive") => true,
_ => false,
}
}
}

impl pallet_tx_pause::Config for Runtime {
type RuntimeEvent = RuntimeEvent;
type RuntimeCall = RuntimeCall;
type PauseOrigin = EnsureRoot<AccountId>;
type UnpauseOrigin = EnsureRoot<AccountId>;
type WhitelistedCalls = TxPauseWhitelistedCalls;
type MaxNameLen = ConstU32<256>;
type WeightInfo = pallet_tx_pause::weights::SubstrateWeight<Runtime>;
}

#[derive_impl(frame_system::config_preludes::SolochainDefaultConfig)]
impl frame_system::Config for Runtime {
type BaseCallFilter = InsideBoth<Everything, TxPause>;
type BlockWeights = RuntimeBlockWeights;
type BlockLength = RuntimeBlockLength;
type DbWeight = RocksDbWeight;
Expand Down Expand Up @@ -1405,6 +1429,9 @@ mod runtime {
#[runtime::pallet_index(66)]
pub type FastUnstake = pallet_fast_unstake::Pallet<Runtime>;

#[runtime::pallet_index(69)]
pub type TxPause = pallet_tx_pause::Pallet<Runtime>;

#[runtime::pallet_index(72)]
pub type MultiBlockMigrations = pallet_migrations::Pallet<Runtime>;

Expand Down Expand Up @@ -1926,6 +1953,7 @@ mod benches {
[pallet_storage_handler, StorageHandler]
[pallet_oss, Oss]
[pallet_cacher, Cacher]
[pallet_tx_pause, TxPause]
);
}

Expand Down Expand Up @@ -2636,4 +2664,4 @@ mod tests {
size,
);
}
}
}