Fixes for agricultural drought hazard assessment and crop table #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included initial_SM, sowing_SM and deficit_start inside the crop loop. Set initial_SM and sowing_SM = AWC. Set kc = kc_in for the days outside the growing period, both before s and after h as specified in Allen 1998. Created mask to select the correct growing period days when averaging ETa at the end of the crop loop. Corrected wrong parameter in crop_table for beans, lg fractions did not add up to 1 before.
Removed sowing soil moisture, no more needed since water balance is calculated also outside the growing period now Corrected rooting depths, assigned to RD[0] for outside the growing period Corrected bug in crop table
Effective precipitation is now calculated for the whole year, not just the growing period. ETa_rf for the first day is set = ETc, meaning that on day==0 we assume maximum evapotranspiration potential. Alternative is setting ETa_rf=0, but it should not make a big difference as the value is very low for Jan 1st anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial_SManddeficit_startand assumption that year starts at full capacity by settinginitial_SM = AWC.kc = kc_infor the days outside the growing period, both beforesand afterhas specified in Allen 1998,daily_rooting_depth = RD[0]and effective precipitation calculated for the whole year. When averagingETaparameters at the end, the growing period is then isolated by masking. Removesowing_SMwhich is no longer needed.ETa_rf = ETcfor the first day (day==0). (The alternative is settingETa_rf=0, but it should not make a big difference as the value is very low for Jan 1st anyway.)season_startfor maize in climate zone 3.AWC < 0criterion to mask oceans.