Upgrade to Java 21: Dockerfile, Spring Boot 3.4.3, and Maven#96
Open
devin-ai-integration[bot] wants to merge 2 commits intoDevOpsfrom
Open
Upgrade to Java 21: Dockerfile, Spring Boot 3.4.3, and Maven#96devin-ai-integration[bot] wants to merge 2 commits intoDevOpsfrom
devin-ai-integration[bot] wants to merge 2 commits intoDevOpsfrom
Conversation
Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…and mysql-connector-j Co-Authored-By: Matthew Guerra <matthew.guerra@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to Java 21: Dockerfile, Spring Boot 3.4.3, and Maven
Summary
Adds a new
Dockerfile.java21and upgradespom.xmlto fully target Java 21. The originalDockerfileremains unchanged for Java 17 fallback.Dockerfile.java21 (new file):
maven:3.8.3-openjdk-17→maven:3.9-eclipse-temurin-21openjdk:17-alpine→eclipse-temurin:21-jre-alpine(openjdk images are deprecated past JDK 17)MAINTAINERdirectivepom.xml updates:
3.3.3→3.4.3<java.version>17→21maven-compiler-plugin3.8.0→3.13.0with<source>/<target>changed from1.8to21mysql:mysql-connector-java:8.0.33→com.mysql:mysql-connector-j(version now managed by Spring Boot BOM)Review & Testing Checklist for Human
mvn clean install: Neither the Maven build nor Docker build was tested. Verify all dependencies resolve and the project compiles successfully against Java 21.docker build -f Dockerfile.java21 -t bankapp:java21 .and verify the app starts and connects to MySQL.maven:3.9-eclipse-temurin-21andeclipse-temurin:21-jre-alpineare valid published tags.Suggested test plan: Build with Maven → build Docker image → run with
docker-compose(updating image reference to use-f Dockerfile.java21) → verify login, registration, deposit, withdrawal, and transfer flows against MySQL.Notes
Dockerfilefor Java 17 is untouched.Requested by: @matthewguerra-cog
Link to Devin run