feat: Migrate from Java 17 to Java 21#99
Open
devin-ai-integration[bot] wants to merge 2 commits intoDevOpsfrom
Open
feat: Migrate from Java 17 to Java 21#99devin-ai-integration[bot] wants to merge 2 commits intoDevOpsfrom
devin-ai-integration[bot] wants to merge 2 commits intoDevOpsfrom
Conversation
Co-Authored-By: Joao Esteves <joao.esteves@cognition.ai>
Co-Authored-By: Joao Esteves <joao.esteves@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the project from Java 17 to Java 21 across build config, Docker images, and documentation. Also rewrites
README.mdfor improved readability (proper markdown headings, table of contents, tech stack table, removal of raw HTML).Key changes:
java.version17 → 21; removedmaven-compiler-pluginthat was forcing Java 1.8 source/targetmaven:3.9.6-eclipse-temurin-21,eclipse-temurin:21-jre-alpine) since official OpenJDK Docker images don't publish Java 21 Alpine variantsopenjdk-17-jre→openjdk-21-jrein Jenkins install; full rewrite replacing HTML<b>/<mark>tags with standard markdown, adding ToC and structured sectionsSpring Boot version intentionally kept at 3.3.3 (already supports Java 21 since 3.2.0+).
Review & Testing Checklist for Human
maven:3.9.6-eclipse-temurin-21andeclipse-temurin:21-jre-alpineare valid tags on Docker Hub. The original task suggestedmaven:3.8.3-openjdk-21andopenjdk:21-alpine, but those don't exist — the replacements chosen here need to be validated.docker build .) to confirm both stages resolve and the app compiles successfully under Java 21maven-compiler-pluginremoval doesn't affect any other build behavior (Spring Boot parent should handle compiler settings viajava.versionproperty)Notes
<!-- Spring Boot 3.2.0+ supports Java 21 -->) on the version line is informational but could be considered noise — remove if unwanted.Requested by: @joao-cognition
Link to Devin run