feat: React + TypeScript Vite project setup (Phase 1 migration infrastructure)#169
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
feat: React + TypeScript Vite project setup (Phase 1 migration infrastructure)#169devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Create react-app/ with Vite + React + TypeScript template - Install React Router v6, TanStack Query, Workbox, SCSS (sass) - Configure VitePWA plugin with Workbox service worker and manifest - Set up project structure: components, hooks, context, types, pages, utils - Migrate PWA manifest and icon assets from Angular app - Configure SCSS preprocessing support in Vite Co-Authored-By: Eashan Sinha <eashan.sinha@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: React + TypeScript Vite project setup (Phase 1 migration infrastructure)
Summary
Creates a new
react-app/directory containing a Vite + React + TypeScript project as the foundation for migrating the Angular2-HN Hacker News PWA. This is Phase 1 (infrastructure only) of a multi-phase migration.What's included:
main.tsxsrc/manifest.json)components/,hooks/,context/,types/,pages/,utils/HNStory,HNComment,HNUser,Settings,FeedType)Review & Testing Checklist for Human
rm -rf node_modules && npm install && npm run buildinreact-app/— verifysasspackage is properly listed in devDependencies (the dependency shuffling during setup may have dropped it)vite-plugin-pwav1.2.0 works correctly with Vite 7.3.1 (build passes but runtime service worker behavior is untested)src/types/index.tsalign with expectations from parallel migration tracksindex.htmltitle from "react-app" to "React HN" and consider updating faviconTest Plan
cd react-app && npm install && npm run build— should complete without errorsnpm run dev— should start dev server on localhost:5173Notes
tsconfig.node.jsonhasallowJs: trueadded as a workaround for vite-plugin-pwa type compatibility with Vite 7scss: {}config block in vite.config.ts is intentional (theapi: 'modern-compiler'option caused type errors)workbox-precaching, etc.) are not directly installed — vite-plugin-pwa bundles them internallyLink to Devin run: https://app.devin.ai/sessions/23b9a7750ae94da3ac6861f813f3ccd4
Requested by: @eashansinha