feat: Migrate Angular 9 Hacker News app to React with Vite + TypeScript#171
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
feat: Migrate Angular 9 Hacker News app to React with Vite + TypeScript#171devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Replace Angular framework with React 18 + React Router v6 - Convert Angular services to async/await utility functions - Convert SettingsService to React Context API with useSettings hook - Convert all Angular components to React functional components - Replace RxJS Observables with fetch + async/await - Set up Vite build system with TypeScript strict mode - Implement lazy loading for ItemDetails and UserProfile routes - Set up PWA with vite-plugin-pwa (Workbox) - Migrate all SCSS styles preserving theme system (default/night/AMOLED) - Move static assets to public/ directory per Vite conventions Co-Authored-By: Eashan Sinha <eashan.sinha@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Migrate Angular 9 Hacker News app to React 18 + Vite
Summary
Complete rewrite of the Angular 9 Hacker News client to React 18 with Vite and TypeScript. All Angular constructs are replaced with React equivalents:
vite-plugin-pwafor service worker supportReact.lazy()/Suspensefor code-splitting (ItemDetails,UserProfile)async/awaitwithfetchSettingsContextwithuseSettingshook)src/assetstopublic/per Vite conventionsDeleted all Angular-specific files (angular.json, polyfills, e2e/protractor, zone.js, karma, tslint, ngsw-config, etc.) and replaced
yarn.lockwithpackage-lock.json.Local Testing Screenshots
News Feed (

/news/1) — numbered list, pagination, header with nav links and settings gear:Item Details (

/item/:id) — story metadata with nested, collapsible comment threads:Review & Testing Checklist for Human
This is a full framework rewrite (113 files changed). Careful manual review is essential.
npm install && npm run dev, openhttp://localhost:5173, and confirm all feed types (news, newest, show, ask, jobs) load with correct data, pagination, and scroll-to-top behavior[-]/[+]) functionality anddangerouslySetInnerHTMLrenders content safelynode-hnapi.herokuapp.com/user/:id) returned 404 for all users. Verify whether this is also broken on the original Angular app or a regressionnpm run build && npm run preview, check DevTools → Application for the service worker registration and manifestRecommended test plan:
npm install && npm run dev, navigate all feed types, click into a story with comments, toggle all 3 themes, adjust font size / list spacing in settings, then try the user profile link.Notes
@importrules (Dart Sass 3.0 migration needed in future) — not errorsdangerouslySetInnerHTMLusage for comment/item content mirrors the original Angular[innerHTML]bindingLink to Devin run: https://app.devin.ai/sessions/4aa1f0dc3dde4fe1a714706107fa5861
Requested by: @eashansinha