Skip to content

Migrate to Java 17 and Spring Boot 3.2; Jakarta migration; remove Joda-Time; dependency and CI updates#331

Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1770343594-java17-migration
Open

Migrate to Java 17 and Spring Boot 3.2; Jakarta migration; remove Joda-Time; dependency and CI updates#331
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1770343594-java17-migration

Conversation

@devin-ai-integration
Copy link

@devin-ai-integration devin-ai-integration bot commented Feb 6, 2026

…or java.time, update security config, upgrade deps, update CI, fix DGS PageInfo + JWT for JJWT 0.12

Co-Authored-By: milind@cognition.ai <milind@cognition.ai>
@devin-ai-integration
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

.body(comment.getBody())
.updatedAt(ISODateTimeFormat.dateTime().withZoneUTC().print(comment.getCreatedAt()))
.createdAt(ISODateTimeFormat.dateTime().withZoneUTC().print(comment.getCreatedAt()))
.updatedAt(DateTimeFormatter.ISO_INSTANT.format(comment.getCreatedAt()))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Comment updatedAt field incorrectly uses createdAt value

In CommentDatafetcher.buildCommentResult(), the updatedAt field is incorrectly set using comment.getCreatedAt() instead of comment.getUpdatedAt(). This means GraphQL responses for comments will always show the same value for both createdAt and updatedAt, even if the comment was actually updated.

Root Cause

The CommentData class at src/main/java/io/spring/application/data/CommentData.java:19-20 has both createdAt and updatedAt fields:

private Instant createdAt;
private Instant updatedAt;

However, the buildCommentResult method uses getCreatedAt() for both fields:

.updatedAt(DateTimeFormatter.ISO_INSTANT.format(comment.getCreatedAt()))
.createdAt(DateTimeFormatter.ISO_INSTANT.format(comment.getCreatedAt()))

Impact: GraphQL clients querying comment data will receive incorrect updatedAt timestamps, making it impossible to determine when a comment was last modified.

Suggested change
.updatedAt(DateTimeFormatter.ISO_INSTANT.format(comment.getCreatedAt()))
.updatedAt(DateTimeFormatter.ISO_INSTANT.format(comment.getUpdatedAt()))
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants