Extract Reference Data Service from TraderX Monorepo#2
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Extract Reference Data Service from TraderX Monorepo#2devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Copy complete reference-data service from traderXCognitiondemos monorepo
- Create standalone Dockerfile with /app working directory and port 18085
- Include S&P 500 companies CSV data file
- Preserve API contract: GET /stocks and GET /stocks/{ticker} endpoints
- Update README.md with comprehensive standalone service documentation
- Service tested and verified working with all endpoints responding correctly
- No external dependencies - reads from CSV file on startup
- Integration points documented for Trade Service and Web Frontend
Co-Authored-By: Samir Chaudhry <schaudhry123@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract Reference Data Service from TraderX Monorepo
This PR extracts the reference data service from the
COG-GTM/traderXCognitiondemosmonorepo into a standalone microservice repository. The service provides REST API access to S&P 500 company data for ticker symbols and company names.Changes Made
Service Extraction
/reference-datadirectory structure from monorepo to repository rootsrc/), tests (test/), and configuration files/data/s-and-p-500-companies.csvopenapi.yaml)Standalone Configuration
Dockerfilewith/appworking directorynpm run startAPI Contract Preservation
Documentation
REFERENCE_DATA_HOSTenvironment variable)Testing Results
Local Testing Completed ✅
The service was successfully tested locally with all endpoints working correctly:
Service Verification
/stocks,/stocks/:ticker,/healthIntegration Points
For Trade Service
Set the
REFERENCE_DATA_HOSTenvironment variable to point to this service:For Web Frontend
Configure the frontend to make direct REST calls to this service's URL.
Files Added/Modified
New Files (25 total):
Dockerfile- Standalone Docker configurationsrc/- Complete NestJS application source codedata/s-and-p-500-companies.csv- S&P 500 companies datasetopenapi.yaml- API specificationpackage.json- Node.js dependencies and scripts.eslintrc.js,.prettierrc,nest-cli.json,tsconfig.jsonModified Files:
README.md- Comprehensive standalone service documentationNext Steps
After this PR is merged, the original monorepo can be updated to point to this external service, but that will be handled in a separate task.
Link to Devin run: https://app.devin.ai/sessions/048fc560be1843c0bb83357f5e5abfad
Requested by: Samir Chaudhry (samir@cognition.ai)