Add authors for core dictionary #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current list is based on those with >10 lines changed in the git repository, plus those who contributed definitions to the DDL1 version.
vaitkus
reviewed
Jan 20, 2026
vaitkus
reviewed
Jan 20, 2026
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
nautolycus
reviewed
Jan 20, 2026
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
The CIF output routines used by the pretty printer did not properly handle leading whitespace for semicolon strings.
vaitkus
approved these changes
Feb 1, 2026
Collaborator
vaitkus
left a comment
vaitkus
left a comment
There was a problem hiding this comment.
Looks good to me.
We could merge this as is or wait for a few more people to respond.
@rowlesmr , @jcbollinger would you like your DOIs or/and emails to be included in the next release of the dictionary?
Contributor
Author
|
I think we'll just merge and if the others wish more details to be included that's a simple PR from them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #560 . The present list was created from those with >10 lines changed in the git repository, plus those who contributed definitions to the DDL1 version. I am not proposing to add Orcid IDs or emails for retired authors or those active only on the DDL1 dictionary.
Obviously not ready for merging until we've resolved which authors want what information included.
@rowlesmr @vaitkus @jcbollinger please edit PR or comment below regarding inclusion of email and/or Orcid identifier.