Addressed Issue 41: was annoying #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 4, 2022
nashirj
reviewed
Dec 4, 2022
| .container { | ||
| @import "css/FeedStyles.css"; | ||
| @import "css/IngredientFeed.css"; | ||
| /* .container { |
Contributor
There was a problem hiding this comment.
If you're not using the commented out code, it can be deleted - this applies everywhere
Comment on lines
180
to
181
| /* TODO(41): If the styles for this and ingredient are identical, make them share | ||
| css. If not, just extract this into a separate css file */ |
Contributor
There was a problem hiding this comment.
Can delete these comments for TODO(41) everywhere
| @@ -0,0 +1,113 @@ | |||
| :root { | |||
| --our-green: #008600; | |||
Contributor
There was a problem hiding this comment.
smart-chef-green instead of our-green
nashirj
approved these changes
Dec 5, 2022
Contributor
|
After you address the other comments you can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.