Skip to content

Fix rounding bug. #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmholmes wants to merge 3 commits into
base: 242-era5-support
Choose a base branch
from
Open

Fix rounding bug. #80

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59e23ea
Fix rounding bug.
rmholmes Feb 24, 2023
b7d9614
Add assert to catch call read-no-data case.
rmholmes Mar 8, 2023
bfa2062
Put an if around the read_data to prevent call.
rmholmes Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions libforcing/src/ncvar.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ subroutine ncvar_refresh(self, filename, &
! Initialise start date and calendar
call self%get_time_metadata(time_varid, self%start_date, self%calendar, &
self%units_as_seconds)
self%dt = int((self%times(2) - self%times(1))*self%units_as_seconds)
self%dt = nint((self%times(2) - self%times(1))*self%units_as_seconds)

status = nf90_get_att(self%ncid, time_varid, "bounds", time_bnds_name)
if (status == nf90_noerr) then
Expand Down Expand Up @@ -331,9 +331,11 @@ subroutine ncvar_read_data(self, indx, dataout)
self%cur_time_cache_size = left_to_read
endif

call read_data(self%ncid, self%varid, self%name, indx, &
self%cur_time_cache_size, self%data_cache)

if (self%cur_time_cache_size > 0) then
call read_data(self%ncid, self%varid, self%name, indx, &
self%cur_time_cache_size, self%data_cache)
endif

do i=1, self%cur_time_cache_size
self%cached_indices(i) = indx + (i - 1)
enddo
Expand Down