Skip to content

Comments

Added Seperated Helium and CO Core Masses to the Documentation#745

Merged
katiebreivik merged 2 commits intoCOSMIC-PopSynth:developfrom
MarkGM02:massc-core-docs
Feb 6, 2026
Merged

Added Seperated Helium and CO Core Masses to the Documentation#745
katiebreivik merged 2 commits intoCOSMIC-PopSynth:developfrom
MarkGM02:massc-core-docs

Conversation

@MarkGM02
Copy link
Contributor

@MarkGM02 MarkGM02 commented Feb 4, 2026

Minimal change so the documentation is up to date.

  • Updated bpp/bcm column docs to replace massc_* with split core columns:
    • massc_he_layer_*
    • massc_co_layer_*
  • Updated interactive inifile convergence options to use the massc_co_layer_* column names.

@MarkGM02
Copy link
Contributor Author

MarkGM02 commented Feb 4, 2026

Also changed the table dimensions in docs/pages/output_info.rst so that the new long column names rendered without error!

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.82%. Comparing base (8772c07) to head (72238cf).
⚠️ Report is 129 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #745      +/-   ##
===========================================
- Coverage    86.91%   77.82%   -9.09%     
===========================================
  Files           40       50      +10     
  Lines        25542    27436    +1894     
  Branches         0      920     +920     
===========================================
- Hits         22198    21350     -848     
- Misses        3344     5812    +2468     
- Partials         0      274     +274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarkGM02
Copy link
Contributor Author

MarkGM02 commented Feb 6, 2026

Updated the definition of remnantflag so that its reliance on rembar_massloss is clearer!

Copy link
Collaborator

@katiebreivik katiebreivik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @MarkGM02

I'll merge this now!

@katiebreivik katiebreivik merged commit a38b32a into COSMIC-PopSynth:develop Feb 6, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants