Clean up Params.ini, handle m2_min=None#749
Merged
TomWagg merged 11 commits intoCOSMIC-PopSynth:developfrom Feb 9, 2026
Merged
Clean up Params.ini, handle m2_min=None#749TomWagg merged 11 commits intoCOSMIC-PopSynth:developfrom
TomWagg merged 11 commits intoCOSMIC-PopSynth:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #749 +/- ##
===========================================
- Coverage 86.91% 77.82% -9.09%
===========================================
Files 40 50 +10
Lines 25542 27456 +1914
Branches 0 920 +920
===========================================
- Hits 22198 21365 -833
- Misses 3344 5817 +2473
- Partials 0 274 +274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the parameter documentation and configuration options for binary population synthesis in the
examples/Params.inifile and the associated UI schema insrc/cosmic/data/cosmic-settings.json. The changes clarify option descriptions, add new models and parameters, and improve consistency across documentation and settings.Key changes include:
New Models and Parameters:
martinez26model option forporb_model, which usessana12for massive binaries (≥8 M☉) andraghavan10for lower-mass binaries, as used in Martinez+2026.keep_singles, to control whether single stars are retained in the sampled population, with documentation and UI support. [1] [2]Clarifications and Consistency Improvements:
qminorm2_minshould be specified as non-default (not None or 0), and updated option descriptions accordingly in both the INI and JSON files. [1] [2] [3] [4]hewind,xi,bhsigmafrac,rembar_massloss,epsnov,rejuv_fac, and others. [1] [2] [3] [4] [5] [6] [7]Model and Option Updates:
offner22tooffner23for the mass-dependent binary fraction model.kickflagto allow use of the old Kiel & Hurley 2009 prescription for binary orbital changes, and set the default to 5.maltsev_modeto 0 and expanded documentation for Maltsev remnant mass prescription parameters.gamma = 0.0for no angular momentum loss,acc_lim = 0.0for fully nonconservative mass transfer). [1] [2]Formatting and Syntax Corrections:
convergence_limitsto use double quotes for JSON compatibility. [1] [2]These changes improve the usability, clarity, and flexibility of the configuration and documentation for users and developers.