Open
Conversation
Removed the default for apply-convergence-limits because it is already defined in Params.ini. Otherwise, cosmic-pop throws an error about conflicting statements even if the user didn't specify anything on the command line about apply-convergence-limits. Also, fixed a minor typo.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #754 +/- ##
===========================================
- Coverage 86.91% 77.82% -9.09%
===========================================
Files 40 50 +10
Lines 25542 27456 +1914
Branches 0 920 +920
===========================================
- Hits 22198 21365 -833
- Misses 3344 5817 +2473
- Partials 0 274 +274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Hey @cferrus -- can you combine the PR's you've submitted into a single PR? Since they are mostly typo fixes it will be easier to keep track if they aren't spread across several different submissions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the default for apply-convergence-limits because it is already defined in Params.ini. Otherwise, cosmic-pop throws an error about conflicting statements even if the user didn't specify anything on the command line about apply-convergence-limits. Also, fixed a minor typo.