Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #755 +/- ##
===========================================
- Coverage 86.91% 77.94% -8.97%
===========================================
Files 40 50 +10
Lines 25542 27396 +1854
Branches 0 859 +859
===========================================
- Hits 22198 21353 -845
- Misses 3344 5769 +2425
- Partials 0 274 +274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@katiebreivik I recommend reviewing this before #756 |
katiebreivik
approved these changes
Feb 17, 2026
Collaborator
katiebreivik
left a comment
There was a problem hiding this comment.
I did not, in fact, review this before the other PR, but I think we are good nonetheless. Thanks @TomWagg !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a crack at some of the weirdos I've found recently with the GDB setup and I have fixed all of my test cases at least.
Changes are:
evol_type==11when SNe occur during CEstb=sep=0for cases where AIC caused a WD to explode and leave behind no remnant (evolve_type==9)kstar=15was assigned its previous epoch mass after merging during a CE and the merger product goes SNTo discuss: