Skip to content

Comments

Edge case bug fixes#755

Merged
TomWagg merged 8 commits intoCOSMIC-PopSynth:developfrom
TomWagg:weirdos
Feb 17, 2026
Merged

Edge case bug fixes#755
TomWagg merged 8 commits intoCOSMIC-PopSynth:developfrom
TomWagg:weirdos

Conversation

@TomWagg
Copy link
Collaborator

@TomWagg TomWagg commented Feb 16, 2026

I took a crack at some of the weirdos I've found recently with the GDB setup and I have fixed all of my test cases at least.

Changes are:

  • Ensure disruptions are logged with evol_type==11 when SNe occur during CEs
  • Set tb=sep=0 for cases where AIC caused a WD to explode and leave behind no remnant (evolve_type==9)
  • Remove bug where kstar=15 was assigned its previous epoch mass after merging during a CE and the merger product goes SN

To discuss:

  1. For that last one I think I am correct to comment out these chunks of code, since Katie seems to have commented out an identical chunk in 2023 elsewhere in the code
  2. For AIC of a WD -> should we be logging this in the bpp
  3. Similarly, a CE -> merger -> SN is only logged as CE -> SN. I think we should have a row for the merger too no?

@TomWagg TomWagg self-assigned this Feb 16, 2026
@TomWagg TomWagg added the bug label Feb 16, 2026
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.94%. Comparing base (8772c07) to head (2a0abe3).
⚠️ Report is 134 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/src/evolv2.f 0.00% 4 Missing ⚠️
src/cosmic/src/comenv.f 0.00% 1 Missing and 1 partial ⚠️
src/cosmic/_version.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #755      +/-   ##
===========================================
- Coverage    86.91%   77.94%   -8.97%     
===========================================
  Files           40       50      +10     
  Lines        25542    27396    +1854     
  Branches         0      859     +859     
===========================================
- Hits         22198    21353     -845     
- Misses        3344     5769    +2425     
- Partials         0      274     +274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomWagg
Copy link
Collaborator Author

TomWagg commented Feb 17, 2026

@katiebreivik I recommend reviewing this before #756

Copy link
Collaborator

@katiebreivik katiebreivik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not, in fact, review this before the other PR, but I think we are good nonetheless. Thanks @TomWagg !

@TomWagg TomWagg merged commit 10fbcd4 into COSMIC-PopSynth:develop Feb 17, 2026
4 of 6 checks passed
@TomWagg TomWagg deleted the weirdos branch February 17, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNe during CE events don't log a disruption in BPP Systems that unmerge Massive massless remnants 😅

2 participants