Skip to content

Comments

Add LBV_flag and change default LBV winds to follow Hurley+2000 (plus new docs stuff)#761

Merged
TomWagg merged 16 commits intoCOSMIC-PopSynth:developfrom
TomWagg:lbv
Feb 18, 2026
Merged

Add LBV_flag and change default LBV winds to follow Hurley+2000 (plus new docs stuff)#761
TomWagg merged 16 commits intoCOSMIC-PopSynth:developfrom
TomWagg:lbv

Conversation

@TomWagg
Copy link
Collaborator

@TomWagg TomWagg commented Feb 18, 2026

  • Fixes:

    • Ensure first timestep of kstar=7 has the correct luminosity after stripping within hrdiag.f
  • Additions/changes:

    • Add new setting LBV_flag which allows one to turn off LBV winds, use Hurley+2000, or use Belcyznski+2008
    • Change the default LBV winds to Hurley
    • Changed default behaviour of windflag=2/3 to add LBV winds rather than erase other winds
  • Documentation:

    • Start new settings gallery in the documentation. This is intended to show plots for every flag eventually and demo what it changes
    • Tag settings/options with the version they were added in the docs page and auto link them to release they were added in

@TomWagg TomWagg self-assigned this Feb 18, 2026
@TomWagg TomWagg added enhancement docs Improvements to the documentation labels Feb 18, 2026
@github-actions github-actions bot added the needs-cmc-review PR touches cosmic core settings and needs CMC review label Feb 18, 2026
@github-actions
Copy link
Contributor

🚨 CMC review requested

This pull request modifies one or more of:

  • src/cosmic/evolve.py
  • src/cosmic/data/cosmic-settings.json (only flagged when category: "bse" key-count changes)

Trigger: evolve file changed, probably needs CMC review

A CMC developer should review this PR to ensure corresponding changes are propagated upstream as needed.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 46.15385% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.99%. Comparing base (8772c07) to head (082472a).
⚠️ Report is 136 commits behind head on develop.

Files with missing lines Patch % Lines
src/cosmic/src/mlwind.f 35.29% 10 Missing and 1 partial ⚠️
src/cosmic/_version.py 0.00% 1 Missing ⚠️
src/cosmic/evolve.py 0.00% 1 Missing ⚠️
src/cosmic/src/hrdiag.f 85.71% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (46.15%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #761      +/-   ##
===========================================
- Coverage    86.91%   77.99%   -8.91%     
===========================================
  Files           40       50      +10     
  Lines        25542    27446    +1904     
  Branches         0      857     +857     
===========================================
- Hits         22198    21406     -792     
- Misses        3344     5754    +2410     
- Partials         0      286     +286     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomWagg TomWagg merged commit 35ead56 into COSMIC-PopSynth:develop Feb 18, 2026
5 of 7 checks passed
@TomWagg TomWagg deleted the lbv branch February 18, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements to the documentation enhancement needs-cmc-review PR touches cosmic core settings and needs CMC review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant