Check for SNe immediately after CEs#765
Open
TomWagg wants to merge 5 commits intoCOSMIC-PopSynth:developfrom
Open
Check for SNe immediately after CEs#765TomWagg wants to merge 5 commits intoCOSMIC-PopSynth:developfrom
TomWagg wants to merge 5 commits intoCOSMIC-PopSynth:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #765 +/- ##
===========================================
- Coverage 86.91% 77.80% -9.10%
===========================================
Files 40 50 +10
Lines 25542 27510 +1968
Branches 0 875 +875
===========================================
- Hits 22198 21404 -794
- Misses 3344 5819 +2475
- Partials 0 287 +287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code didn't check for SNe after a call to
hrdiagafter a CE. This fixes #764.Definitely check how I did this, I copied the block of code from the other hrdiag calls and made some slight adjustments to ensure that the evolve_type=8 is still logged each time. I think it works (it fixes my weirdos definitely).
I've also switched the version 3.7.4 so you can release easily.
Oh and I also cleaned up the issue templates.