Merged
Conversation
larrylaa
requested changes
Apr 9, 2025
Contributor
larrylaa
left a comment
There was a problem hiding this comment.
The frontend for the onboarding flow looks really nice, however I am encountering an issue where my screen view goes to the mobile view despite being on desktop.
Can you fix this?
The backend API call doesn't work right now because I don't have it implemented, so I will be handling that. Just fix the screen shrinking.
I've attached a photo below.
Contributor
Author
|
Ok, I updated the branch. The issue should be fixed. |
larrylaa
added a commit
that referenced
this pull request
Apr 20, 2025
* fix: like/follow routes * feat: Rebeccals onboard (#43) * Updated Onboarding Page * More onboarding updates * Fixed onboard container being too small. Added link to home slideshow. * changed onboard so its public * chore: workflow double run fix * chore: double unit test run fix --------- Co-authored-by: Rebecca Smith <2145912+Rebeccals@users.noreply.github.com> Co-authored-by: Larry La <larryquocla@gmail.com> * chore: drop db to fix everything * feat: profile page (#44) * feat. like and follow buttons * feat. new profile page draft --------- Co-authored-by: luisd101 <luisdominguezrock@gmail.com> * feat: onboarding flow + user auth basics (#45) * feat: edit user schema to support onboarding * feat: user onboard backend route * feat: check if onboarded * chore: eslint rule update * feat: working onboarding flow * feat: added the match score algorithm * feat: student profile backend (#46) * feat: react routing user id * chore: api call * feat: projects showing * feaT: working scroll * feat: project permissions * feat: completed profile page * chore: email * chore: update the edit modal * chore: passed in userdata * feat: update works * fix: major not showing * chore: final touch up * fix: placeholder profile image, redirect to correct page on back button * chore: pull data and pass into matchscoreutils * chore: add for home page also * chore: abstract user error msg * fix: MatchScoreUtils.js to calculate new user values as well as correctly outputs weighted scores * feat: new calculation logic * chore: make tags be added on project creation * chore: make score sseem more natural * fix: page error on empty tags * fix: sizing broke * feat: about page (#49) * Updated About page * chore: hide form --------- Co-authored-by: Rebecca Smith <2145912+Rebeccals@users.noreply.github.com> Co-authored-by: Larry La <larryquocla@gmail.com> --------- Co-authored-by: Rebecca Smith <2145912+Rebeccals1@users.noreply.github.com> Co-authored-by: Rebecca Smith <2145912+Rebeccals@users.noreply.github.com> Co-authored-by: luisd101 <luisdominguezrock@gmail.com> Co-authored-by: ColumnSkunky <wfgs03@gmail.com> Co-authored-by: William Garcia <102125255+ColumnSkunky@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes made to onboard page:
✅ Validation
Required that:
🧭 Progress Handling
🌀 Animated Transitions
📋 Backend Integration