Pylint #32
Merged
Pylint #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikCald
approved these changes
Nov 21, 2025
noodlekid
requested changes
Nov 21, 2025
noodlekid
left a comment
noodlekid
left a comment
There was a problem hiding this comment.
LGTM, just some nit picky typing/formatting, up to you to resolve but I do think type enforcement should be mandatory.
noodlekid
approved these changes
Nov 23, 2025
ConnorNeed
added a commit
that referenced
this pull request
Nov 23, 2025
Merged
ConnorNeed
added a commit
that referenced
this pull request
Nov 23, 2025
Jayden442
added a commit
that referenced
this pull request
Jan 15, 2026
* port from old repo * Removed logging for debugging * drive mode Minor fixes Arm dummy * Update servo to pub/sub for all modes Linting and minor comments slash in topic name Small pi servo changes Remove unnecessary import Remove more imports formatting * Pi constant and readded toggle lights Formatting Radians in config arm servo name servo service revert * Nav launch (#21) * fix: navigation launch * chore: update readme * chore: add convenience script to source ros env * chore: add zed folder to volumes for dev container * chore: format * chore: add gridmap filter dependancy * chore: add host zed SDK to setup package * Microservice video streaming (#19) * feat: template for distributed streaming setup * style: spelling * Navigation tuning (#23) * feat: split nav2 and mapping launches * feat: reduce layers on traversability_postprocessing * chore: format * chore: clean up parameters passed in * Aruco changes (#24) * chore: move plugins to video_streaming package * chore: seperate gstreamer plugins * docs: file extension * chore: allow camera work in linux dev container * feat: optimize aruco detection * feat: ros2 image source gst-plugin * updating limits with encoder movement (#29) Co-authored-by: Jetson <softlead@curover.ca> * Optimize Decay Computation in radialInflateSerial (#16) * Optimize Decay Computation in radialInflateSerial * fix: get preserve cost inflation working * style: autoformat --------- Co-authored-by: ConnorN <connor.needham2015@gmail.com> * Offset issues (#33) * feat: use talon sensor offset support * tune: fix sensor offsets and limits * style: format * fix: current ticks issue * Arm launch clean up (#31) * chore: manual clean up * chore: ai cleanup * chore: remove redundant files * fix: remove duplicate rsp * fix: move ros2_control_node to individual node * Add open loop drive option to talon drive controller (#28) * feat: open loop drive option * Format code and test --------- Co-authored-by: Jetson <softlead@curover.ca> * Pylint (#32) * fix: all import errors * fix: unused varibles * chore: add pylint * fix: code review comments * Feature/srt component (#36) * Fix build: Reduce parallel workers to 1 to save memory * feat: add SRT node for video streaming with GStreamer integration * fix: restore dynamic parallel worker count in build script * Style: auto-format launch file with black * Fix: syntax error and formatting in srt_node.cpp * Refactor: improve code formatting and organization in SrtNode class * Refactor: update CMakeLists.txt and package.xml for improved dependency management; modify SRT node parameters for testing * Refactor: improve formatting and organization in SrtNode class; streamline try-catch blocks and enhance pipeline description logging * Refactor: update SRT node parameters for improved configuration; change default srt_uri and add test_mode parameter * Refactor: improve formatting and organization in SrtNode class; streamline parameter declarations and subscription bindings * improve code formatting * fix: pipeline fixes during testing --------- Co-authored-by: Ju <bangmar@iclod.com> Co-authored-by: ConnorN <connor.needham2015@gmail.com> * port from old repo Removed logging for debugging Linting and minor comments slash in topic name Small pi servo changes Remove unnecessary import Remove more imports formatting Removed max_num_servo formatting * Fixed build errors and warnings Fixed typing on science Fix drive mode servo client * Allow multiple servos Fixed config Check all ports for all servo types linting * Removed duplicates in pi servo * Lint compliance --------- Co-authored-by: Connor Needham <129120300+ConnorNeed@users.noreply.github.com> Co-authored-by: ConnorN <connor.needham2015@gmail.com> Co-authored-by: Darren Wallace <63486143+TheWalrus368@users.noreply.github.com> Co-authored-by: Jetson <softlead@curover.ca> Co-authored-by: Jack Wong <120768324+jackcwong2007@users.noreply.github.com> Co-authored-by: Erik <43829793+ErikCald@users.noreply.github.com> Co-authored-by: 潤辰| Runchen Zhao <runchenzhao@cmail.carleton.ca> Co-authored-by: Ju <bangmar@iclod.com>
Jayden442
added a commit
that referenced
this pull request
Jan 22, 2026
* port from old repo * Removed logging for debugging * Linting and minor comments * slash in topic name * Small pi servo changes * Remove unnecessary import Remove more imports formatting * Removed max_num_servo * formatting * [Draft] Refactor Servo Architecture Part 2 (#34) * port from old repo * Removed logging for debugging * drive mode Minor fixes Arm dummy * Update servo to pub/sub for all modes Linting and minor comments slash in topic name Small pi servo changes Remove unnecessary import Remove more imports formatting * Pi constant and readded toggle lights Formatting Radians in config arm servo name servo service revert * Nav launch (#21) * fix: navigation launch * chore: update readme * chore: add convenience script to source ros env * chore: add zed folder to volumes for dev container * chore: format * chore: add gridmap filter dependancy * chore: add host zed SDK to setup package * Microservice video streaming (#19) * feat: template for distributed streaming setup * style: spelling * Navigation tuning (#23) * feat: split nav2 and mapping launches * feat: reduce layers on traversability_postprocessing * chore: format * chore: clean up parameters passed in * Aruco changes (#24) * chore: move plugins to video_streaming package * chore: seperate gstreamer plugins * docs: file extension * chore: allow camera work in linux dev container * feat: optimize aruco detection * feat: ros2 image source gst-plugin * updating limits with encoder movement (#29) Co-authored-by: Jetson <softlead@curover.ca> * Optimize Decay Computation in radialInflateSerial (#16) * Optimize Decay Computation in radialInflateSerial * fix: get preserve cost inflation working * style: autoformat --------- Co-authored-by: ConnorN <connor.needham2015@gmail.com> * Offset issues (#33) * feat: use talon sensor offset support * tune: fix sensor offsets and limits * style: format * fix: current ticks issue * Arm launch clean up (#31) * chore: manual clean up * chore: ai cleanup * chore: remove redundant files * fix: remove duplicate rsp * fix: move ros2_control_node to individual node * Add open loop drive option to talon drive controller (#28) * feat: open loop drive option * Format code and test --------- Co-authored-by: Jetson <softlead@curover.ca> * Pylint (#32) * fix: all import errors * fix: unused varibles * chore: add pylint * fix: code review comments * Feature/srt component (#36) * Fix build: Reduce parallel workers to 1 to save memory * feat: add SRT node for video streaming with GStreamer integration * fix: restore dynamic parallel worker count in build script * Style: auto-format launch file with black * Fix: syntax error and formatting in srt_node.cpp * Refactor: improve code formatting and organization in SrtNode class * Refactor: update CMakeLists.txt and package.xml for improved dependency management; modify SRT node parameters for testing * Refactor: improve formatting and organization in SrtNode class; streamline try-catch blocks and enhance pipeline description logging * Refactor: update SRT node parameters for improved configuration; change default srt_uri and add test_mode parameter * Refactor: improve formatting and organization in SrtNode class; streamline parameter declarations and subscription bindings * improve code formatting * fix: pipeline fixes during testing --------- Co-authored-by: Ju <bangmar@iclod.com> Co-authored-by: ConnorN <connor.needham2015@gmail.com> * port from old repo Removed logging for debugging Linting and minor comments slash in topic name Small pi servo changes Remove unnecessary import Remove more imports formatting Removed max_num_servo formatting * Fixed build errors and warnings Fixed typing on science Fix drive mode servo client * Allow multiple servos Fixed config Check all ports for all servo types linting * Removed duplicates in pi servo * Lint compliance --------- Co-authored-by: Connor Needham <129120300+ConnorNeed@users.noreply.github.com> Co-authored-by: ConnorN <connor.needham2015@gmail.com> Co-authored-by: Darren Wallace <63486143+TheWalrus368@users.noreply.github.com> Co-authored-by: Jetson <softlead@curover.ca> Co-authored-by: Jack Wong <120768324+jackcwong2007@users.noreply.github.com> Co-authored-by: Erik <43829793+ErikCald@users.noreply.github.com> Co-authored-by: 潤辰| Runchen Zhao <runchenzhao@cmail.carleton.ca> Co-authored-by: Ju <bangmar@iclod.com> --------- Co-authored-by: Connor Needham <129120300+ConnorNeed@users.noreply.github.com> Co-authored-by: ConnorN <connor.needham2015@gmail.com> Co-authored-by: Darren Wallace <63486143+TheWalrus368@users.noreply.github.com> Co-authored-by: Jetson <softlead@curover.ca> Co-authored-by: Jack Wong <120768324+jackcwong2007@users.noreply.github.com> Co-authored-by: Erik <43829793+ErikCald@users.noreply.github.com> Co-authored-by: 潤辰| Runchen Zhao <runchenzhao@cmail.carleton.ca> Co-authored-by: Ju <bangmar@iclod.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't added the pylint check to the ci/cd pipeline because there are 2 failing unused varible checks in the gps launch files. I didn't want to fix those and add conflicts because I know they are getting changed in #30.
Ideally we use an even stronger linter but this is a good start.
This pull request primarily focuses on cleaning up imports, simplifying launch files, and addressing minor code quality issues across several packages. The most significant changes include refining launch file dependencies, removing unused or redundant imports, and making small bug fixes to improve code clarity and maintainability.
Launch file and dependency cleanup:
SetEnvironmentVariable,ExecuteProcess,IncludeLaunchDescription, and others) from multiple launch files to simplify dependencies and improve readability (src/Bringup/launch/core.launch.py,src/Bringup/launch/drive.launch.py,src/Bringup/launch/video_streaming.launch.py,src/Arm/arm_urdf/launch/launch.py,src/Arm/arm_srdf/launch/talon.launch.py,src/HW-Devices/science_sensors/launch/talon.launch.py,src/Nav/gps/launch/rover.launch.py,src/Nav/localization/launch/navsat.launch.py) [1] [2] [3] [4] [5] [6] [7] [8].slam_cmdinsrc/Nav/localization/launch/localization.launch.py, and a commented-out block forrobot_state_publisherinsrc/Nav/elevation_mapping/launch/elevationMapping_launch.py) [1] [2] [3].Bug fixes and code quality improvements:
Nonewhen a video capture service is unavailable incapture_imageto avoid returning an undefined value (src/HW-Devices/science_sensors/science_sensors/panoramic.py).cv2.aruco.detectMarkersto ignore unused variables (src/Cameras/computer_vision/computer_vision/zed_aruco_detector.py).stellarnet_driver3module to use an absolute import (src/HW-Devices/science_sensors/science_sensors/stellarnet_demo.py).Simplification and removal of unused variables:
math,os,time,subprocess,GeoPose, etc.) (src/Nav/cprt_gridmap_filters/scripts/visualize_decay_rate.py,src/Nav/gps/gps/heading_pub_node.py,src/Nav/localization/localization/republish_odometry.py,src/HW-Devices/science_sensors/science_sensors/panoramic.py,src/HW-Devices/science_sensors/launch/talon.launch.py,src/Nav/nav_commanders/nav_commanders/incremental_gps_commander.py) [1] [2] [3] [4] [5] [6].Pylint configuration:
.pylintrcconfiguration file to standardize linting behavior, specifying enabled/disabled checks and ignoring thethird-partydirectory.Asynchronous request handling:
futurevariables when making asynchronous service calls, as the result is not used (src/HW-Devices/science_sensors/science_sensors/microscope_control.py,src/HW-Devices/servo_pkg/servo_pkg/servo_client.py) [1] [2].