feat: add augment_from_xarray for EOProduct #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothey-cs
changed the title
timothey-cs
force-pushed
the
feat/add_argument_from_xarray
branch
from
7d40d45 to
556fc1a
Compare
timothey-cs
force-pushed
the
feat/add_argument_from_xarray
branch
from
556fc1a to
9ec4e69
Compare
sbrunato
requested changes
Dec 8, 2025
timothey-cs
force-pushed
the
feat/add_argument_from_xarray
branch
from
cb42244 to
2732f2d
Compare
sbrunato
requested changes
Dec 15, 2025
timothey-cs
force-pushed
the
feat/add_argument_from_xarray
branch
from
e30a35c to
3d582f3
Compare
sbrunato
requested changes
Dec 19, 2025
timothey-cs
force-pushed
the
feat/add_argument_from_xarray
branch
from
e3d9642 to
fa09195
Compare
timothey-cs
force-pushed
the
feat/add_argument_from_xarray
branch
from
fa09195 to
aab2a24
Compare
sbrunato
requested changes
Jan 5, 2026
timothey-cs
force-pushed
the
feat/add_argument_from_xarray
branch
from
bbea061 to
1a474f9
Compare
sbrunato
requested changes
Jan 6, 2026
sbrunato
requested changes
Jan 6, 2026
Collaborator
There was a problem hiding this comment.
please add tests. Total coverage went from 86.54% to 66.51%
Collaborator
There was a problem hiding this comment.
please move new "sub-methods" to another file like utils/metadata.py
timothey-cs
force-pushed
the
feat/add_argument_from_xarray
branch
from
9e1ef7c to
f790f7b
Compare
timothey-cs
force-pushed
the
feat/add_argument_from_xarray
branch
from
5c8cd2f to
662498a
Compare
sbrunato
requested changes
Jan 9, 2026
Comment on lines
+105
to
+106
| "description": var.attrs.get("long_name", ""), | ||
| "nodata": var.attrs.get("nodata", -9999), |
Collaborator
There was a problem hiding this comment.
do not use default values. If value is not found, do not add description / nodata
Comment on lines
+105
to
+106
| "description": var.attrs.get("long_name", ""), | ||
| "nodata": var.attrs.get("nodata", -9999), |
Collaborator
There was a problem hiding this comment.
for nodata, please also check _FillValue and missing_value in data_array.encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
Add augment_from_xarray function to EOProduct.
It takes values from to_xarray and add cube:dimensions and cube:variables to product properties