fix(core): wrong credentials sharing #1970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: daac988 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
|
Code Coverage (Windows)DetailsDiff against developResults for commit: daac988 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
cauriol
approved these changes
Dec 11, 2025
sbrunato
requested changes
Jan 7, 2026
Collaborator
sbrunato
left a comment
sbrunato
left a comment
There was a problem hiding this comment.
the problem here is not that cop_marine does not need credentials but that credentials are shared between providers when it should not.
Instead of adding this new parameter need_credentials, better update PluginConfig.matches_target_auth method with:
# both match
if target_matching_conf and sort_dict(target_matching_conf) == sort_dict(
matching_conf
) and target_matching_url and target_matching_url == matching_url:
return True
# conf matches and no matching_url expected
if target_matching_conf and sort_dict(target_matching_conf) == sort_dict(
matching_conf
) and not target_matching_url:
return True
# url matches and no matching_conf expected
if target_matching_url and target_matching_url == matching_url and not target_matching_conf:
return True
return False
anesson-cs
force-pushed
the
wrong-credentials-sharing
branch
from
daac988 to
d91faae
Compare
Collaborator
|
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: 7241c73 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
|
Code Coverage (Windows)DetailsDiff against developResults for commit: 7241c73 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
anesson-cs
force-pushed
the
wrong-credentials-sharing
branch
from
d91faae to
7241c73
Compare
sbrunato
approved these changes
Jan 9, 2026
sbrunato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to share credentials between plugins only if it should be the case, i.e. in three cases:
matching_urland do not have a differentmatching_confmatching_confand do not have a differentmatching_urlmatching_urlandmatching_confIt is fixed by updating
PluginConfig.matches_target_authmethod.Furthermore, credentials received from other providers were updated until there is no matching
authconfiguration anymore while the first one was enough, it is fixed now.fedeo_cedahas been added to theuser_conf_template.ymlfile.