fix: asset name harmonisation for S1_SAR_GRD #1983
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: 81a6f47 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
|
Code Coverage (Windows)DetailsDiff against developResults for commit: 81a6f47 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
jlahovnik
requested changes
Jan 7, 2026
Collaborator
jlahovnik
left a comment
jlahovnik
left a comment
There was a problem hiding this comment.
Please add a test case and update the PR description!
cauriol
force-pushed
the
asset_name_harmonisation
branch
from
f71a118 to
774456a
Compare
jlahovnik
approved these changes
Jan 8, 2026
cauriol
changed the title
sbrunato
requested changes
Jan 9, 2026
Collaborator
There was a problem hiding this comment.
on S1_SAR_GRD from earth_search, manifest.safe gets renamed to manifest.s when it shouldn't
| self.product.driver.guess_asset_key_and_roles( | ||
| "s3://foo/1/28/0/preview.png?collection=foo&items=foo", self.product | ||
| ), | ||
| ("previ.png", ["overview"]), |
Collaborator
There was a problem hiding this comment.
previ.png is not the expected output. Please update driver patterns of chars that could be included in other words (ew, iw, sm, raw) with something like r"(?<![A-Za-z])ew(?![A-Za-z])", to avoid letters on both sides
Collaborator
There was a problem hiding this comment.
these fixes should also be applied to other drivers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes asset naming issues for Sentinel-1 assets coming from Planetary Computer and creodias_s3.
Asset names are now normalized to the name.extension format.
For example:
previ.png?foo → previ.png
calibration-vh-12a34b.xml → calibration-vh.xml
This PR updates the ASSET_KEYS_PATTERNS_ROLES and REPLACE_PATTERNS lists in sentinel1.py and adds new tests.