Skip to content

Conversation

@ulises0516
Copy link
Collaborator

Fix BarChart Clipping on Small Devices with Adjusted Margins

Referenced Issue: #27

Reviewers (if applicable): @j3rrythomas

Summary

This PR addresses the clipping issue of the BarChart component on most screen sizes by manually adjusting the margins. Although this change resolves clipping for nearly all devices, the following devices still experience issues:

  • iPhone 12 Pro (390×844)
  • iPhone SE (375 x 667)
  • Samsung Galaxy S8 (360 x 740)
  • Galaxy Z Fold 5 (344 x 882)

Details

  • Clipping Fixed:
    Manual margin adjustments have been applied to prevent the chart content from overflowing its container on small screens.

  • Squished Bar Issue:
    One thing I saw was that the bars still appear slightly squished on these devices. Future iterations could leverage dynamic adjustments such as onResize to potentially fix this by making custom margin for smaller screen sizes.

Next Steps

  • I think we should monitor feedback and performance on the affected devices (unlikely due to professors mostly using > tablet devices).
  • Consider dynamic approaches (such as onResize-driven margin changes) in subsequent updates to improve the squished bar issue.

@ulises0516 ulises0516 added the bug Something isn't working label Apr 16, 2025
@ulises0516 ulises0516 self-assigned this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants