Student analytics drawer #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j3rrythomas
reviewed
May 31, 2025
|
|
||
| export const StudentAnalyticsDrawer = ({ studentId, courseId }: Props) => { | ||
| const { toast } = useToast(); | ||
| const [isOpen, setIsOpen] = useState(false); |
Collaborator
There was a problem hiding this comment.
if we dont custom open/close logic, you can remove this state and remove the props from the Sheet component. it should work
j3rrythomas
reviewed
May 31, 2025
|
|
||
| <div className="space-y-2 max-h-72 overflow-y-auto"> | ||
| {questionsForDate.map((question, idx) => ( | ||
| <div key={idx} className="grid grid-cols-3 gap-2"> |
Collaborator
There was a problem hiding this comment.
make the table with the questions a separate component
j3rrythomas
requested changes
May 31, 2025
Collaborator
j3rrythomas
left a comment
j3rrythomas
left a comment
There was a problem hiding this comment.
Fix as per comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Made the drawer analytics page (StudentAnalyticsDrawer.tsx). Used the donut chart component that nishitha made. analytics.ts is where I get the backend data.