Skip to content

Conversation

@n1sh1thaS
Copy link
Collaborator

Changes

  • allow users to order the marketplace list by price, most recent, and alphabetical
  • set the default ordering to most recent

Testing

  • manually confirmed that products were listed in the correct order for each ordering option

Tracking

Resolves #74

@chase-of-the-fjords
Copy link
Collaborator

Looks just about perfect, but a few comments:

  1. There's the same issue again of having the filter open by default, not sure why it's back but it does need to be fixed here too.

  2. When the product under the filter is saved, the heart appears above the filter, shown here:

image

  1. This is actually for the other search options too, but clicking the text should also select each option (so clicking the "Most Recent" text should sort by Most Recent, not just clicking the box).

  2. Finally, I'd add a price (high-low) option too. I think it could be useful.

Copy link
Collaborator

@chase-of-the-fjords chase-of-the-fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ I keep forgetting to comment as a review

@chase-of-the-fjords
Copy link
Collaborator

It looks like there's new merge conflicts - it's probably from the email PR I just merged. But otherwise the changes here look good,

I would like 2 more quick changes though:

  1. Now the filter is closed by default which is great! But when I click anywhere on the screen after loading the page it automatically opens. Not sure why.

  2. I feel like when you click outside the filter box it should close by default, if you can implement that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants