Skip to content

Conversation

@n1sh1thaS
Copy link
Collaborator

Changes

  • created a responsive pagination bar
  • display 12 products per page
  • edited the get products endpoints to pass in the current page number and return the total number of pages

Testing

  • manually verified that pages displayed the correct number of products and the pagination bar changed based on how many products match the current query

Tracking

Resolves #80

@westonz7042 westonz7042 self-requested a review May 16, 2025 18:41
Copy link
Collaborator

@westonz7042 westonz7042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@chase-of-the-fjords chase-of-the-fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! The only thing is that it's branched off of your filters/sorting branch right now, so I don't want to push this until those changes are all fixed and ready. Those changes should be pretty fast, then I can merge all of it.

@chase-of-the-fjords
Copy link
Collaborator

Oh also it has merge conflicts right now, so make sure those are fixed before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants