Minor fixes #189 #194
Merged
Minor fixes #189 #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly edited 'No Data' messages.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
LC0229
previously approved these changes
Nov 15, 2025
…ges the 'No Data' message based on the Applications, Companies, Connect, and SavedApplications pages.
n1sh1thaS
requested changes
Nov 16, 2025
Collaborator
n1sh1thaS
left a comment
n1sh1thaS
left a comment
There was a problem hiding this comment.
Great work!
I did notice one issue with the Applications and Saved Applications pages. If the user does not have any applications at all, it correctly displays a message saying that they have not added any applications yet. However, the same message shows up if the user is searching/filtering for something that does not exist (e.g. filtering by OA status but they don't have any apps in that status). Would you be able to edit the message to say something like "no matches for this query" in that case?
n1sh1thaS
previously approved these changes
Nov 16, 2025
LC0229
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alumni and Companies pages display No Data messages when filters do not match.
"Sort By" dropdowns now read "Filter" on several pages.
Fixed broken Instagram and Linktree links.
Minor spelling fixes.