Some NPC.HitModifiers.SourceDamage patches:#100
Open
Habble53 wants to merge 421 commits intoCalamityTeam:1.4.4from
Open
Some NPC.HitModifiers.SourceDamage patches:#100Habble53 wants to merge 421 commits intoCalamityTeam:1.4.4from
Habble53 wants to merge 421 commits intoCalamityTeam:1.4.4from
Conversation
This previously caused loading errors for me even though the strong reference to the music mod should've prevented that
Slab Crab spawn uses `OceanMonster` condition (which makes it impossible to spawn) when it should use `CaveJellyfish` condition like the other Abyssal NPCs.
Removed weird item time manipulation line on some summons causing bugs to another mods like Summoner's Association.
2 - All four Candle buffs are now mutually exclusive. 3 - Unlike other buff stations, Cirrus Candles persist through death. 4 - Changed all Cirrus Candles to be Pink rarity (matching Cirrus) and cost 2 platinum, because you only need one of them. 5 - Buffed Blue Candle from 5% to 10% movement speed, wing time, and acceleration. 6 - Buffed Pink Candle from 0.4% HP/s to 0.6% HP/s 7 - Buffed Yellow Candle from 1.05x damage to 1.07x damage. No longer ignores DR, but still ignores defense. 8 - Yellow Candle is no longer a tag debuff and does not apply to enemies in any way. 9 - Purple Candle is mechanically unchanged.
… Style 1 Broadswords.
…as intended. 2 - Fixed Yellow Candle being placebo, for real this time.
…our or something.
2 - Fixed Old Duke Remix Seed enrage. 3 - Renderer Manager render state edits. 4 - Fixed lava generating in the Sunken Sea and Abyss. 5 - Fixed Brimstone Slag walls generating in incorrect locations. 6 - Mechanic Shed no longer generates in space, hopefully.
2 - Fixed the yoyo burst damage exploit 3 - Fixed Mining Potion and Hand of Creation tooltips 4 - Fixed Grax's tooltip 5 - Fixed Flame Waker Boots' heat debuff multiplier not applying on projectile hits
Including removal of most biome-specific material drops Includes the Hardmode ore crate bug fix at long last Also adds alternative Auric Ore obtainment method
Ozzatron
dismissed
their stale review
The merge-base changed after approval.
CONTAINS UNSAFE/POINTERS, IF CALAMITY RULES THIS AS A NO-GO, THIS IS WHERE IT WAS INTRODUCED
# Conflicts: # Systems/CalamityModWaterStyle.cs
This PR enables the unsafe flag which blocks in-game building.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced globally available projectile instances of HitModifiers.SourceDamage modification with HitModifiers.TargetDamageMultiplier, so as to prevent it from being inherited in NPC.HitInfo.SourceDamage and doubled up in cases where other mods may spawn additional OnHit projectiles that inherit HitInfo.SourceDamage for accurate OnHit interactions. Recommended to move to HitModifiers.FinalDamage and redone as such or implement defensive mechanisms that don't let additional projectiles inherit SourceDamage, like globally tagging projectiles (and their children by chaining projectile tags with e.g.
source is EntitySource_Parent parent && parent.Entity is Projectile proj && proj.Calamity().WeaponSource) in OnSpawn by checking EntitySource_ItemUse_WithAmmo. A few other less important examples were left as is, including Thanatos closed vent DR and GFB seed interaction(s?) like Profaned Guardians.