Skip to content

Android specific Bug fixes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ronit-kadwane wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Android specific Bug fixes #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc03225
IUnityAdsListener listener implemented
ronit-kadwane May 30, 2019
eb57836
sdk version updated
ronit-kadwane May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ buildscript {
apply plugin: 'com.android.library'

android {
compileSdkVersion 23
buildToolsVersion "23.0.1"
compileSdkVersion 28
buildToolsVersion "28.0.3"

defaultConfig {
minSdkVersion 16
targetSdkVersion 22
targetSdkVersion 28
versionCode 1
versionName "1.0"
}
Expand All @@ -34,4 +34,4 @@ dependencies {
compile 'com.facebook.react:react-native:+'
compile fileTree(dir: "libs", include: ["*.aar"])
}


5 changes: 2 additions & 3 deletions android/src/main/java/com/unityads/RNUnityAdsModuleModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import com.facebook.react.modules.core.DeviceEventManagerModule;
import android.support.annotation.Nullable;

public class RNUnityAdsModuleModule extends ReactContextBaseJavaModule {
public class RNUnityAdsModuleModule extends ReactContextBaseJavaModule implements IUnityAdsListener {

private final ReactApplicationContext reactContext;

Expand Down Expand Up @@ -129,5 +129,4 @@ public void onUnityAdsError(UnityAds.UnityAdsError error, String message) {

sendEvent(reactContext,"Error", params);
}

}
}