-
Notifications
You must be signed in to change notification settings - Fork 30
Remove 760m/s boundary on μ formula (G/Gmax param) in HH model #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a86e60e
Update helper_hh_calibration.py
xia-fr 9667afe
Minor comment edit
xia-fr 4164ef9
Adjusting test corresponding to hh calibration
xia-fr 95708e6
Fixing hh calibration test
xia-fr 8eb0fb8
Modified test file for param from profile
xia-fr 4772d42
Minor formatting edit
xia-fr 540c5a5
Update test_class_hh_calibration.py benchmarks
xia-fr 73c13fe
Minor formatting edits
xia-fr db10016
Commas formatting
xia-fr 47576d7
Update test for deprecation warning
xia-fr 7c7878c
Formatting fix
xia-fr 662fe8f
Python version and changelog edits
xia-fr 0807f4f
Workflow edit
xia-fr b92276d
Reverting test change
xia-fr 60b2cd0
More workflow changes
xia-fr 7eec1ac
Reverting some changes + pytest adjustment
xia-fr 66e592c
Fix testenv
xia-fr 1dbd3a0
Changelog and readme edits
xia-fr d209c02
Reverting some changes
xia-fr 76e501c
Formatting and test_helper_generic edit
xia-fr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| 0.00076244 0.00139754 0.000110308 0.000104122 0.00010717 | ||
| 0.00076244 0.00139754 0.000110308 0.000104122 0.00010116 | ||
| 100 100 100 100 100 | ||
| 0.000314063 0.000448739 0.000608263 0.000837192 0.000940767 | ||
| 1 1 1 1 1 | ||
| 0.919 0.919 0.919 0.919 0.919 | ||
| 2.69257e+07 6.70011e+07 1.46383e+08 2.41314e+09 3.37484e+09 | ||
| 0.206245 0.211334 0.257876 1 1 | ||
| 0.206245 0.211334 0.257876 0.0686843 0.0662230 | ||
| 27822.5 65841.5 148710 815621 1.13262e+06 | ||
| 0.908794 0.89794 0.861759 0.981156 0.977538 | ||
| 0.908794 0.897940 0.861759 0.688091 0.684472 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a place in README.md that says "requires python ≥ 3.9". Can you update that place too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the line that said "3.9" under the section for "Supported Python versions", so it just shows 3.10 to 3.13