Open
Conversation
…io include dirs properly
…mplain about this despite it not being documented
Contributor
|
This is a good idea, but we are in the process of a major refactor of cameera-interface. We need to plan how to integrate this with the refactor, so, for now, I recommend you keep this on your branch for your current needs. We'll definitely want these kind of updates for the refactor, but we are focusing on the code structure initially and haven't dealt with the build yet. |
This was referenced May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is intended to start modernising the CMake build system, just a little bit. If there is acceptance of these type of things I'll go further in future because modernising CMake build systems is a weird hobby of mine.
The reasons are:
Nothing here should break any existing buyild instructions. I have tried out those instructions in an ubuntu 22.04 distrobox and it still appears to work. But please let me know if anything looks concerning. I would like to have this merged so I can work on a reasonably simple Docker build process. Currently t hat build process would be highly compillicated.