Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add certificate search and display system with API endpoints and UI #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Add certificate search and display system with API endpoints and UI #27
Changes from all commits
ed502f293bbb25ecf5e4e3c59812File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure
Code scanning / CodeQL
Log entries created from user input High
Copilot Autofix
AI about 1 month ago
To fix the problem, sanitize the
studentNameparameter to remove (or otherwise escape) any newline or carriage return characters before logging it. This should be done immediately before the logging statement, only for the purpose of recording the log, so as not to affect the actual application logic or query.The fix involves:
safeStudentName, just before logging.safeStudentNamethe value ofstudentNamewith all newline-related characters removed (\r,\n, and optionally others).safeStudentNameto the logger in place of the rawstudentName.Only lines in the method containing the logged user data should be changed. No changes are needed elsewhere.
Check failure
Code scanning / CodeQL
Log entries created from user input High
Copilot Autofix
AI about 1 month ago
The best way to fix this problem is to sanitize the
studentNamevariable before logging it. Specifically, remove any line break characters from the value, since log forging usually relies on inserting newlines. In general terms, update the logging line at line 99 (and optionally at line 93 for consistency) to log a sanitized version ofstudentNamein place of the raw input.Detailed steps:
studentNameby removing (replacing) all occurrences of\rand\n.No new imports are required, as
string.Replaceis built in.Only lines within the
SearchCertificatesmethod inapi/CourseRegistration.API/Controllers/CertificatesController.csare changed.Uh oh!
There was an error while loading. Please reload this page.