-
-
Notifications
You must be signed in to change notification settings - Fork 67
Complete Electron platform test assertions in channel_self tests #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/add-electron-platform
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
The test now properly verifies that all 4 channels (production, beta, development, no_access) are returned for Electron platform, since all channels have electron=true by default in the migration. Co-authored-by: riderx <4084527+riderx@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR completes the Electron platform compatibility test in channel_self.test.ts by adding specific channel assertions that were previously missing. The test now validates that all 4 seed channels (production, beta, development, no_access) are returned for Electron platform requests, matching the pattern used in iOS and Android tests.
Changes:
- Added channel name assertions to verify all 4 expected channels are returned
- Added length assertion to confirm exactly 4 channels match the filtering criteria
- Follows the established test pattern from iOS/Android platform tests



Summary
The Electron platform compatibility test in
channel_self.test.tswas incomplete—it verified response success and array structure but didn't assert which channels should be returned, unlike the iOS and Android tests.Added specific channel assertions following the existing test pattern:
production,beta,development,no_access)This is correct because the migration adds
electroncolumn withDEFAULT true, making all seed channels Electron-compatible by default.Test plan
The test validates GET
/channel_selfwithplatform=electron,is_emulator=false,is_prod=truereturns all compatible channels with proper filtering based on:electron=true)allow_device=true)allow_prod=true)public=trueORallow_device_self_set=true)Screenshots
N/A - Backend test changes only
Checklist
bun run lint:backend && bun run lint.accordingly.
my tests
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.