Clarify queue system retry mechanism handles manifest file_size update retries #1467
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The on_manifest_create trigger was skipping the database update when getSize returned 0, causing file_size to remain 0 in production. Now it throws an error on size=0 to trigger queue retry, ensuring the update always happens when a valid size is available. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Address review feedback: when updateError occurs, throw simpleError instead of just logging so the queue can retry the operation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2 tasks
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Copilot
AI
changed the title
[WIP] Fix feedback on manifest file_size update for queue system retries
Clarify queue system retry mechanism handles manifest file_size update retries
Jan 19, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback on #1466 regarding retry loop concerns. The
pgmqqueue system enforces a maximum of 5 retry attempts (read_ct > 5cleanup), making the current error-throwing implementation safe and correct.When
getSize()returns 0, the function throwssimpleError, triggering queue retries. The queue automatically deletes messages after 5 failed attempts, providing a window for S3 files to become ready while preventing infinite loops.No code changes required - the existing implementation in #1466 correctly leverages the queue's built-in retry mechanism.
Test plan
No changes made. Original PR #1466 test plan applies.
Screenshots
N/A - clarification PR, no code changes
Checklist
bun run lint:backend && bun run lint.accordingly.
my tests
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.