Skip to content

Implement AB testing #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
riderx merged 10 commits into from
Aug 24, 2023
Merged

Implement AB testing #276

riderx merged 10 commits into from
Aug 24, 2023

Conversation

@WcaleNieWolny
Copy link
Contributor

@WcaleNieWolny WcaleNieWolny commented Aug 19, 2023 •
edited
Loading

This PR implements this issue

Here is a recorded demo (Sorry for the length)

2023-08-19.07-07-00.mp4

@netlify
Copy link

netlify bot commented Aug 19, 2023 •
edited
Loading

❌ Deploy Preview for webcapgo failed.

Name Link
🔨 Latest commit f63384c
🔍 Latest deploy log https://app.netlify.com/sites/webcapgo/deploys/64e6cc791955930008fe6aef

@WcaleNieWolny
Copy link
Contributor Author

WcaleNieWolny commented Aug 19, 2023

image

Is this okay? I am aware that weak crypto = bad but it does not really matter here since the user can just spam update request until he gets the version he wants

@algora-pbc algora-pbc bot mentioned this pull request Aug 19, 2023
Closed
@WcaleNieWolny
Copy link
Contributor Author

WcaleNieWolny commented Aug 19, 2023 •
edited
Loading

Do not merge this just yet please, debounce is broken

@WcaleNieWolny
Copy link
Contributor Author

WcaleNieWolny commented Aug 19, 2023

@riderx Fixed the debounce issue, ready to be merged

WcaleNieWolny and others added 2 commits August 19, 2023 20:27
@WcaleNieWolny @riderx @github-actions
Merge branch main (#1)
049e222 
* fix: plunk leaked key

* chore(release): 10.58.0 [skip netlify]

* fix: test CI

* chore(release): 10.59.0 [skip netlify]

* fix: remove useless code

* chore(release): 10.60.0 [skip netlify]

---------

Co-authored-by: Martin Donadieu <martindonadieu@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@WcaleNieWolny
Rounding error fix
7e36d8c
@WcaleNieWolny WcaleNieWolny mentioned this pull request Aug 22, 2023
Merged
@riderx
Copy link
Member

riderx commented Aug 22, 2023

Can you revert change in CHANGELOG.md android/app/build.gradle ios/App/App.xcodeproj/project.pbxproj and package.json
this shouldn't be changed i think.
After i can merge it

@WcaleNieWolny
Copy link
Contributor Author

WcaleNieWolny commented Aug 22, 2023

@riderx done

@WcaleNieWolny
Copy link
Contributor Author

WcaleNieWolny commented Aug 23, 2023

@riderx Fixed merge conflicts (again, as you added some commits after I did that yesterday)

You can squash commits when you merge

riderx
riderx reviewed Aug 23, 2023
View reviewed changes
@riderx riderx merged commit 935f99e into Cap-go:main Aug 24, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 7 Code Smells

No Coverage information No Coverage information
16.5% 16.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riderx riderx riderx left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WcaleNieWolny @riderx