updated to polymer 2, including documentation & tests. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mer 2 does not seem to have the nice landing page where either documentation or demo can be selected. The url http://127.0.0.1:8081/components/impetus-scroller/ takes you to the documentation. to see the demo, you need to append 'demo'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to use your 2.0-preview branch (didn't seem to be fully functional?), so I updated master to 2.0 on a new branch. Everything seems to be working. Not sure how you want to go about this (or if you even want to bother), since merging this into master will mean no more 1.x version. Also, I'll be working on a 3.0 version very soon.
Your current 1.x demo landing page has a nice feature - it lands you on the docs page, but then has a link to the demo page. It seems that polymer 2 does not have this -- the url http://127.0.0.1:8081/components/impetus-scroller/ takes you to the documentation. To see the demo, you need to manually append 'demo' to the url.
BTW nice component, I likes!