-
Notifications
You must be signed in to change notification settings - Fork 831
Added castability highlighting for cards in hand #9383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jtomse
wants to merge
5
commits into
Card-Forge:master
Choose a base branch
from
jtomse:castability-highlighting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c5c4a88
Added castability highlighting for cards in hand
jtomse 2417ef8
Addressed PR feedback: now checks preference before running canCastCa…
jtomse f0d71ec
Addressed PR feedback: refactored nested loop to use game.findByView …
jtomse 2aefcf6
Wraps method in try/catch to avoids errors thrown during exceptions
jtomse e8f175d
Addressed PR Feedback: Fixed spacing
jtomse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of a misnomer here, since the AI not being able to pay the mana cost doesn't mean its not able to be paid. Also there could be circumstances where there's no legal targets, or other costs are unable to be paid that this would bypass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's really to show if you have the available mana to cast something so you don't have to count in your head. But it doesn't mean there's necessarily a valid target, or that you have enough life to pay the additional cost , or that playing the card won't trigger a game loss, etc. It also doesn't highlight cards with no mana cost that can be played (lands, zero CMC, etc.). It really is just a helper so you don't have to do a manual mana check/count each turn to see if you finally have enough mana of the right kind to cast that creature you've been waiting to cast, or if you've tapped 2 Plains and 3 Islands this turn, do you still have enough available to cast your other UW. Do you think renaming the feature is in order? Something other than castability highlighting like "Mana available" or somthing like that? Lmk what you think.