Skip to content

ci: amarna#19

Open
milancermak wants to merge 2 commits intoCarmineOptions:masterfrom
milancermak:dev/add-amarna
Open

ci: amarna#19
milancermak wants to merge 2 commits intoCarmineOptions:masterfrom
milancermak:dev/add-amarna

Conversation

@milancermak
Copy link
Contributor

This PR adds Amarna, a static code analyzer, to the CI.

At times, it has false positives, but generally it's pretty helpful. For example, it detected an unused import of ACCOUNT_BALANCE_UPPER_BOUND in amm.cairo - but shouldn't it be used in set_account_balance on line 89 instead of POOL_BALANCE_UPPER_BOUND?

Anyway, I hope it'll actually work and run the first time, GitHub Actions can be a bit finicky to set up :)

ondrejsojka added a commit that referenced this pull request Aug 8, 2022
@ondrejsojka
Copy link
Contributor

This works pretty nicely, but for the moment would IMO be a distraction, since the code is a mess and we know it. For the moment, I added a very simple runner that simply checks whether the code can be built or not (see protostar.yml in master) and I'd merge this once LP tokens and option tokens are done and we are free for some cleanup work.

@MarekHauzr
Copy link
Member

This works pretty nicely, but for the moment would IMO be a distraction, since the code is a mess and we know it. For the moment, I added a very simple runner that simply checks whether the code can be built or not (see protostar.yml in master) and I'd merge this once LP tokens and option tokens are done and we are free for some cleanup work.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants