Open
Conversation
ondrejsojka
added a commit
that referenced
this pull request
Aug 8, 2022
Contributor
|
This works pretty nicely, but for the moment would IMO be a distraction, since the code is a mess and we know it. For the moment, I added a very simple runner that simply checks whether the code can be built or not (see protostar.yml in master) and I'd merge this once LP tokens and option tokens are done and we are free for some cleanup work. |
Member
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Amarna, a static code analyzer, to the CI.
At times, it has false positives, but generally it's pretty helpful. For example, it detected an unused import of
ACCOUNT_BALANCE_UPPER_BOUNDinamm.cairo- but shouldn't it be used inset_account_balanceon line 89 instead ofPOOL_BALANCE_UPPER_BOUND?Anyway, I hope it'll actually work and run the first time, GitHub Actions can be a bit finicky to set up :)