Conversation
| echo Conda environment is activated | ||
| cd ../.. | ||
| echo Building package... | ||
| pip install gcastle |
There was a problem hiding this comment.
Need comments on why we do these.
we know the answer but it should be informative nevertheless to others.
causalbench-asu/tests/test.bat
Outdated
| pip install torch | ||
| pip install build | ||
| python -m build | ||
| pip install dist\causalbench_asu-0.1rc3-py3-none-any.whl |
There was a problem hiding this comment.
This will cause issues as we update our versioning, find a way to install the package without explicitly stating the name (...0.1rc3...)
| pip install gcastle | ||
| pip install torch | ||
| pip install build | ||
| python -m build |
There was a problem hiding this comment.
IIRC this should take some arguments to provide the wheel output name.
|
We will have many more tests in the future. Our test suite should have echo "X tests have run, of which Y have completed, Z have failed. The failed tests are: {a,b,c}."
if Z>0:
throw errorAlways catch exceptions and show them with their tracelog. |
causalbench-asu/tests/test.sh
Outdated
| pip install torch | ||
| pip install build | ||
| python -m build | ||
| pip install dist/causalbench_asu-0.1rc3-py3-none-any.whl |
There was a problem hiding this comment.
Follows the issues on the bat file as well.
| @@ -0,0 +1,5 @@ | |||
| from causalbench.modules.task import Task | |||
There was a problem hiding this comment.
Needs comments on what it specifically tests. A successful case? A failed case? A maliciously set case?
|
Needs a manually created context case. context2: Context = Context.create(name='Temporal Context: VAR-LiNGAM, pcmciplus',
description='Test temporal context',
task='discovery.temporal',
datasets=[(dataset2, {'data': 'file1', 'ground_truth': 'file2'})],
models=[model3, model4],
metrics=[metric3, metric4]) |
| response = init_auth() | ||
|
|
||
| assert is_jwt(response), "Response is not in JWT format. Access token could not received" | ||
| print("Response is in JWT format and it is an access token.") No newline at end of file |
There was a problem hiding this comment.
kapkic
left a comment
kapkic
left a comment
There was a problem hiding this comment.
Besides a few comments LGTM!
2 participants
No description provided.