Skip to content

Use explicit void operator for side-effect expression in multiaddr conversion #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wemeetagain merged 2 commits into from
Feb 9, 2026
Merged

Use explicit void operator for side-effect expression in multiaddr conversion #329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb0e8eb
Initial plan
Copilot Feb 9, 2026
eb80f80
Replace standalone side-effect expression with void operator in ip.ts
Copilot Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/discv5/src/util/ip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ export function multiaddrFromSocketAddress(s: SocketAddress): Multiaddr {
export function multiaddrToSocketAddress(multiaddr: Multiaddr): SocketAddress {
let ip: Ip | undefined;
let port: number | undefined;
multiaddr.bytes; // populate internal cache
// Force cache population of bytes property to ensure getComponents() works correctly
void multiaddr.bytes;
for (const component of multiaddr.getComponents()) {
switch (component.code) {
case PROTOCOL["4"]:
Expand Down