-
Notifications
You must be signed in to change notification settings - Fork 28
Refactor cfstore to dataclasses #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
2902ca5
Use a dataclass for CFConfig
jacomago 87c8196
Use set for cf_properties
jacomago 78a72ac
Use dataclass for CFProperty
jacomago 7ebeaff
Add committransaction dataclass
jacomago 981fdab
Add RecordInfo dataclass
jacomago 56bacf7
Add CFPropertyName enum
jacomago d9b1c0c
Add PVStatus enum
jacomago 30f7c07
Create IocInfo Dataclass
jacomago 4965b73
Add CFChannel dataclass
jacomago c03b990
Use static CFProperty methods
jacomago 18d533c
sleep is a float
jacomago fd6210a
CancelledError has no host or port properties
jacomago 6c97c05
Split up commitWithThread
jacomago 3cdf7df
Improve logging
jacomago 17f1cb6
Pull out channel_is_old
jacomago c292d1b
Pull out orphan channel
jacomago 46aec00
pull out handle channel old and new
jacomago 93d861e
pull out get_existing channels
jacomago ec65e3f
pull out handle old channels
jacomago 6efecaa
pull out update_existing_channel_diff_iocid
jacomago d6244dd
pull out create_new_channel
jacomago 94f6317
Rename create_properties to create_ioc_properties
jacomago dc4798e
rename to loads and classmethod
jacomago 51cecc8
Update pydoc, types and comments
jacomago f34d060
Add constant for search strings
jacomago 6d51eb0
Remove extraneous recordType check
jacomago 001ee3b
snake case record type property
jacomago 8ce4bd3
Use pvstatus enum
jacomago c110fe1
snake case recordinfo
jacomago 7237ef6
static method from channelfinder_dict
jacomago 7c9d04b
snake case current time
jacomago 0227c90
snake case start service with lock
jacomago 64af0b3
snake case stop_service_with_lock
jacomago ec23e36
snake case _commit_with_lock
jacomago b4f7977
snake case to_record_infos
jacomago 9024e35
snake case record_infos
jacomago 22a1b1a
record_info like variables snake case
jacomago 82658ff
existing channels snake case
jacomago a711d32
alias_properties rename
jacomago 55cc59e
new_properties snake case
jacomago 2b8d0e0
updateCF not dunder
jacomago 00a602e
Make sure every raise has debug info
jacomago dce0324
not dunder update cf
jacomago c335796
empty string rather than "None"
jacomago 67dea8d
Update infotags examples
jacomago 99ce35e
remove error format strings
jacomago 553d26c
default query limit
jacomago 462a7b8
CFProperty use classmethods
jacomago 45378c4
CFChannel classmethod
jacomago d0e2c4a
rename handle_old_channels to handle_channels
jacomago 1d3204d
simpler if case
jacomago 5e5e7bc
keyword args in using prepareFindArgs
jacomago 1099f01
Remove unnecessary None return
jacomago 628ead3
default for channelcount
jacomago e6e5ffa
snake case commit with thread
jacomago cd33433
Add comments for overriden methods
jacomago 5d021fc
_commit_with_lock submethods to snake case
jacomago a93ea43
static record_info_by_name
jacomago e35136e
reduce passing processor in static methods
jacomago d915481
from dict not from_cf_dict
jacomago 3b1e59d
more snake case
jacomago 0cb5e00
pvstatus to strenum
jacomago 62ecc7d
cfpropertyname as strenum
jacomago 991a550
record property names list set
jacomago f74749e
Specific error class
jacomago File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the commas required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no. Good point. In fact "x,y z" would give ["x,y", "z"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if they aren't required then I would remove them to avoid confusion or change the comment above to say space or comma separated