Refactor docker ioc used in testing recceiver #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-ess
reviewed
Nov 13, 2025
jacomago
force-pushed
the
pullout-server-test-docker
branch
from
6cce958 to
3f45f0c
Compare
jacomago
requested review from
anderslindho,
ralphlange,
shroffk,
simon-ess and
tynanford
Contributor
anderslindho
left a comment
anderslindho
left a comment
There was a problem hiding this comment.
It's an improvement overall, but I would like to see also server/tests/ioc/*.db go down from 2 to 1, and it would be nice if we could get rid of the manual CHANNEL_COUNTs and instead base that on some param fed to the test setup fn(s)
It's also a bit odd that we have to manually match CHANNEL_NAME in tests - you may as well set the entire record name as a macro and just use the same definition
jacomago
force-pushed
the
pullout-server-test-docker
branch
from
eae2a01 to
eaa58fd
Compare
|
anderslindho
approved these changes
Nov 17, 2025
Contributor
anderslindho
left a comment
anderslindho
left a comment
There was a problem hiding this comment.
It's an improvement, but I think my previous summary review comment still stands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre PR for #126 based on code review on that one.