-
Notifications
You must be signed in to change notification settings - Fork 6
Fill in word #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fiabot
wants to merge
33
commits into
CherokeeLanguage:union-team/jan-23-starter-code
Choose a base branch
from
fiabot:fill_in_word
base: union-team/jan-23-starter-code
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fill in word #84
fiabot
wants to merge
33
commits into
CherokeeLanguage:union-team/jan-23-starter-code
from
fiabot:fill_in_word
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unused files * migrations: clean up logic for multiple migrations; migrate misspelled terms * reenable rich phonetics * stub out credits system * allow multiple credit roles * create support for multiple orthographies * WIP: add jw living phrases set (blocked on typos); stop using nfkd ever * malformed regexp * handle drop vowels * try to tame unicode normalization * handle long text more gracefully * allow migrations to drop terms * update living phrases data * handle drop vowels even in detailed phonetics * unused imports * typos * add more context to credits * clean up vocabulary routes, headings, credits * more credit cleanup * only show remove set if user is learning set * typo * make modals more generous with space * add modal to confirm changing current set; make language more user friendly * squash * break vocabulary view into sections; currently learning; new; finished * refactor a ConfirmationModal * change copy on create issue form
* align phonetics and syllabary and let user mouseover to see connection * handle fused sounds * present aligned phonetics to user * syllabary changes needed (phonetics changes need migration) * migrate terms that needed phonetics changes * graceful failure
* create negative button variant for delete actions * use negative button for flag issue in card table * build practice lesson feature * make delete button even bigger and redder
* write the tones wip * create answers with feedback component to share between multiple choice exercises * refactor hook; handle cards with no valid words * handle skdela
* firebase mirroring content * firebase analytics * foo * capture email address! * split lessons out of main store
…in case things go wrong!
…03-14/spring-break-release Spring break release branch!!
…-answer-feedback - make user confirm after wrong answer - clean up getting started widget - clean up dashboard - open faq in new tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally branched from Main so there may be some problems there.
also there are some issue with the sizes of the multiple choice component that need to be addressed.