Fix issues with virus scanners and non-english default encodings #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accessing configuration files CHANGED: Check for access to parent folder and for read permission to the config file before opening the file for reading (prevents issues with virus scanners) Note: Implementation of both changes is loosely based on the mechanics of the MinecraftForge Configuration class. I'd suggest checking this for future reference.
Owner
|
Will fix this when I can test it. I need a (preferrably free) virus scanner and version that I can install to reproduce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGED: Support non-English encodings by forcing UTF-8 support when accessing configuration files
CHANGED: Check for access to parent folder and for read permission to the config file before opening the file for reading (prevents issues with virus scanners)
Note: Implementation of both changes is loosely based on the mechanics of the MinecraftForge Configuration class. I'd suggest checking this for future reference.
The canRead() check does much of the magic, this prompts the virus scanner to scan the file, so it does not need to reject the request to fetch a file descriptor when actually trying to open the file.